On Mon, 21 Jun 2021 at 15:43, tanghy.f...@fujitsu.com < tanghy.f...@fujitsu.com> wrote:
> Hi > > I was doing regression testing according to the PG-doc at [1]. > The modification at 854434c5 seems not correct, could you please take a > check at it? > > >make check PGOPTIONS="-c log_checkpoints=on -c work_mem=50MB" > > The above command reported an error like this: > failed: FATAL: parameter "log_checkpoints" cannot be changed now > > IMHO, as a sighup GUC, log_checkpoints can't be set in PGOPTIONS, is that > correct? > > >make check EXTRA_REGRESS_OPTS="--temp-config=test_postgresql.conf" > > pg_regress: could not open "test_postgresql.conf" to read extra config: No > such file or directory > > I fixed above problem using command like this: > make check EXTRA_REGRESS_OPTS="--temp-config=$(pwd)/test_postgresql.conf" > > Maybe we can change doc description to tell user he/she should specify the > location of " test_postgresql.conf", thoughts? > > [1] https://www.postgresql.org/docs/devel/regress-run.html Yes, that'd make a lot of sense. PGOPTIONS is more suited for client settings. Willing to cook up a quick patch? -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
