On Tue, Jul 20, 2021 at 04:06:17PM -0400, Bruce Momjian wrote: > On Tue, Jul 20, 2021 at 11:03:09AM -0400, Tom Lane wrote: > > The places where you changed "substring(s)" to "substrings" are maybe > > not flat wrong, but I don't think they're improving the text either. > > IIRC, in most of them you get one match if you didn't use the 'g' > > flag, but possibly multiple matches if you did, and the "substring(s)" > > wording is meant to allude to that without taking the space to spell > > it out explicitly. > > I see what you mean --- there can be multiple capture groups, and > multiple match processing if 'g' is used. I think the text using "(s)" > is too complex, so I spelled out the use 'g' and clarified the case of > multiple groups in a single regex. > > Updated patch attached, and I used a larger line context around the > changes to clarify what was being modified.
Patch applied back to PG 13 --- before that, the text supplied as much more minimal. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
