On Fri, 2021-07-30 at 16:20 -0400, Tom Lane wrote: > Laurenz Albe <laurenz.a...@cybertec.at> writes: > > On Wed, 2021-04-28 at 13:24 +0200, Laurenz Albe wrote: > > > On Tue, 2021-04-27 at 14:26 +0000, PG Doc comments form wrote: > > > > If I understand correctly, it would be helpful to add this sentence or a > > > > corrected version of it: "Triggers always execute in the same > > > > transaction as > > > > the triggering event, and if a trigger fails, the transaction is rolled > > > > back." > > > > Here is a proposed patch for this. > > I think this is a good idea, but I felt like you'd added the extra > sentences in not-terribly-well-chosen places. For instance, your > first addition in trigger.sgml is adding to a para that talks about > triggers for tables, while the next para talks about triggers for > views. So it seems unclear whether the statement is meant to apply > to view triggers too. > > I think it'd work out best to make this a separate para after the > one that defines before/after/instead-of triggers. How do you > like the attached?
That is better, and I like your patch. Thanks! Keeping paragraphs short is a good thing. Yours, Laurenz Albe
