On Mon, Mar 30, 2026 at 5:48 PM Hiroki Takamatsu <[email protected]> wrote: > The attached patch: > > 1. rewrites each column description to scope it to the general database > object case, instead of making a false claim about NULL behavior for > all other lock types; > 2. adds a pointer to the detailed per-lock-type prose below; and > 3. documents that apply transaction locks show the subscription OID in > objid.
Thanks for the patch! I agree with the direction. I made a few additional tweaks in the attached version: - Scoped the "references ..." notes for classid and objid to the general database object case as well. - Changed "see below" to point explicitly to the descriptions of the specific lock types below. - Updated the introductory paragraph to mention speculative insertion locks and apply transaction locks. - Linked the subscription OID shown for apply transaction locks to pg_subscription.oid. > I chose not to enumerate all non-object lock types in the column > descriptions, since that seemed easy to let drift again as new lock > types are added. Agreed. The updated patch also avoids enumerating them in the column descriptions and keeps those details in the per-lock-type descriptions. Regards, -- Fujii Masao
v2-0001-doc-clarify-pg_locks-object-identifier-columns.patch
Description: Binary data
