On Sun, Oct 11, 2026 at 6:42 PM Peter Smith <[email protected]> wrote:
> Hi,
>
> I had a look at the parts that were related to logical replication.
>
> Everything seemed "correct" to me, but the patch makes just bare
> minimal changes for single words or commas. That's OK if minimal
> changes is the objective, but there are some places where you might
> consider going further and fixing awkward sentences properly given you
> are changing them anyway. e.g.
>
> Current:
> The ADD TABLES IN SCHEMA, SET TABLES IN SCHEMA, SET ALL TABLES, and
> SET ALL SEQUENCES to a publication requires the invoking user to be a
> superuser.
>
> Patched ("requires" -> "require"):
> The ADD TABLES IN SCHEMA, SET TABLES IN SCHEMA, SET ALL TABLES, and
> SET ALL SEQUENCES to a publication require the invoking user to be a
> superuser.
>
> Suggested:
> The invoking user must be a superuser to use ADD TABLES IN SCHEMA, SET
> TABLES IN SCHEMA, SET ALL TABLES, or SET ALL SEQUENCES.
>
I also came to this conclusion when I reviewed it. I think if punctuation
is put aside because
it is debatable, the patch improves reading by fixing typos and unclear
sentences.
Can we agree to proceed in this direction?
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
>
>
>
