> Hey Arvind, it LGTM with a small change: "* is a shorthand for all the > columns of the selected rows (not including <xref > linkend="ddl-system-columns" endterm="system columns"/>)." What do you > think?
Thanks for the review. I like that wording better. endterm needs the id of an element, not free text, so this form fails the doc check. I used <link linkend="ddl-system-columns">system columns</link> instead, which gives the same rendered text, with "system columns" as the link. The attached v4 has this change. The docs build cleanly with make check and make html. I have also added the patch to the commitfest: https://commitfest.postgresql.org/patch/7599/ Thanks, Arvind Kandpal On Wed, Nov 4, 2026 at 8:18 PM Matemática A3K <[email protected]> wrote: > > On Tue, Nov 3, 2026 at 4:37 AM Arvind Kandpal > <[email protected]> wrote: > > > > > I think if you want to go in that direction, you should refactor saying > > > something like "* is the shorthand for all the user-defined columns (see > > > system columns)". What do you think? > > > > Thanks for the suggestion. Changing the existing sentence is cleaner > > than adding a new one. > > > > The attached v3 changes the first sentence of that paragraph on the > > SELECT reference page to say that * is a shorthand for all the columns > > of the selected rows, not including system columns, with a link to the > > System Columns section. I used "not including system columns" instead > > of "user-defined columns", since the docs don't use that term for this. > > I also dropped the example to keep the change small. > > Hey Arvind, it LGTM with a small change: "* is a shorthand for all the > columns of the selected rows (not including <xref > linkend="ddl-system-columns" endterm="system columns"/>)." What do you > think? -- Arvind Kandpal Junior Software Engineer (+91) 9650266413 www.ksolves.com Years of listing on
From 9b073c28627635a3aecb0cf5089d253daf28e75b Mon Sep 17 00:00:00 2001 From: Arvind Kandpal <[email protected]> Date: Thu, 5 Nov 2026 12:51:09 +0530 Subject: [PATCH v4] doc: Mention that * does not include system columns In the SELECT reference page, say in the description of * in the output list that it does not include system columns, with a link to the System Columns section. Discussion: https://postgr.es/m/178782026936.2606573.10270614257871556...@wrigleys.postgresql.org --- doc/src/sgml/ref/select.sgml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml index 18392f7caec..f58d0031da2 100644 --- a/doc/src/sgml/ref/select.sgml +++ b/doc/src/sgml/ref/select.sgml @@ -1153,7 +1153,8 @@ EXCLUDE NO OTHERS <para> Instead of an expression, <literal>*</literal> can be written in the output list as a shorthand for all the columns of the selected - rows. Also, you can write <literal><replaceable + rows (not including <link linkend="ddl-system-columns">system + columns</link>). Also, you can write <literal><replaceable class="parameter">table_name</replaceable>.*</literal> as a shorthand for the columns coming from just that table. In these cases it is not possible to specify new names with <literal>AS</literal>; -- 2.43.0
