> On 13 Nov 2026, at 10:14, Karen Jex <[email protected]> wrote:

> Commitfest entry: https://commitfest.postgresql.org/patch/7630/

Thanks for the new version, I think this is pretty much done, just a few small
comments from reviewing it again:

     user passwords to connect to the remote server. This avoids storing
-    plain-text user passwords in PostgreSQL system catalogs.
+    cleartext user passwords in PostgreSQL system catalogs.

..and:

-        plain-text user passwords to connect to the remote server.  This
-        avoids storing plain-text user passwords in PostgreSQL system
+        cleartext user passwords to connect to the remote server.  This
+        avoids storing cleartext user passwords in PostgreSQL system

I think there is potential for additional cleanup here since it is the storage
system we are referring to and not an inherent quality of a specific password.
Something like the below (though I don't particularly like the double "in", but
I fail at english today) would be an improvement I think.

    "This avoids storing user passwords in cleartext in PostgreSQL system
    catalogs."

+  <glossentry>
+   <glossterm>Cleartext</glossterm>
+   <glossdef>
+    <para>
+     Unencrypted data; data that exists in an unprotected, readable format
+     during storage or transmission. Sometimes used as a synonym for
+     plaintext; the input to an encryption algorithm.
+    </para>
+   </glossdef>
+  </glossentry>

All data is readable, shouldn't this be specified as "human-readable" to make
it clear?

+  <glossentry>
+   <glossterm>Plain text</glossterm>
+   <glossdef>
+    <para>
+     Unformatted, human-readable text that consists of a sequence of printable
+     characters in a character encoding such as UTF-8.
+    </para>
+   </glossdef>
+  </glossentry>

The UTF-8 part seems distracting and potentially confusing, I think ending the
sentence on "printable characters." would be better.

Attachec v4 have the above changes plus a needed rebase since the pg_dump hunk
didn't apply anymore.

--
Daniel Gustafsson

Attachment: v4-0001-doc-Standardise-cleartext-and-plain-text-terms.patch
Description: Binary data

Reply via email to