On 08/10/2014 03:24 PM, MauMau wrote: > From: "Vik Fearing" <vik.fear...@dalibo.com> >> I noticed that the documentation for pageinspect lists the different >> forks but omits the initialization fork. >> >> Here is a trivial patch to fix that. > > Could you also improve the doc by changing "table" to "relation" in the > description of get_raw_page()? Having a quick look at the code, it > seems that the function can also handle indexes. > > table and returns a copy as a <type>bytea</> value. This allows a
Good catch. I wasn't sure whether using "relation" or "table or index" was better, but after a quick test it seems it works for sequences, too, so I've gone with "relation". It doesn't work with views, of course, but it does work with materialized views. Modified patch attached. -- Vik
*** a/doc/src/sgml/pageinspect.sgml --- b/doc/src/sgml/pageinspect.sgml *************** *** 28,38 **** <listitem> <para> <function>get_raw_page</function> reads the specified block of the named ! table and returns a copy as a <type>bytea</> value. This allows a single time-consistent copy of the block to be obtained. <replaceable>fork</replaceable> should be <literal>'main'</literal> for ! the main data fork, or <literal>'fsm'</literal> for the free space map, ! or <literal>'vm'</literal> for the visibility map. </para> </listitem> </varlistentry> --- 28,39 ---- <listitem> <para> <function>get_raw_page</function> reads the specified block of the named ! relation and returns a copy as a <type>bytea</> value. This allows a single time-consistent copy of the block to be obtained. <replaceable>fork</replaceable> should be <literal>'main'</literal> for ! the main data fork, <literal>'fsm'</literal> for the free space map, ! <literal>'vm'</literal> for the visibility map, or <literal>'init'</literal> ! for the initialization fork. </para> </listitem> </varlistentry>
-- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs