On Sat, Jan 7, 2017 at 10:02 AM, Bruce Momjian <br...@momjian.us> wrote: >> 1) pg_xlogdump --help should mention PGDATA as well for the default >> behavior, and should make clear the default and when -p is defined: >> -p, --path=PATH directory in which to find log segment files >> (default: ./pg_wal) > > Ah, good point. The new output is: > > -p, --path=PATH directory in which to find log segment files > (default: current directory, ./pg_wal, $PGDATA/pg_wal)
Looks good, thanks. >> 2) The documentation does not mention that if a directory is defined >> pg_xlogdump will try to look as well at defined_dir/pg_wal. > > Uh, I think it does in the first sentence: > > Directory in which to find log segment files. I am reading that as "only the current directory", not "the current directory, then current directory + pg_wal". Do you think that this sentence implies that the check routine looks as well at current_dir/pg_wal? > Updated patch attached. + subdirectory of both the current directory and the + <envar>PGDATA</envar> directory. This could say "of both the current directory and *then* the PGDATA directory" to outline the order of the actions taken by the check routine. Just my 2c on the matter. -- Michael -- Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-docs
