Hi Thomas, Sorry for late reply.
>> Thanks Ishii-san and Tom. Here's a patch. Obviously it mostly just >> deletes thousands of lines, but also: I had to preserve the encoding >> number, so there's a hole in the table, > > pg_upgrade fails: > > Performing Upgrade > ------------------ > ... > Setting frozenxid and minmxid counters in new cluster > connection to server on socket "/.../.s.PGSQL.50432" failed: FATAL: > invalid database encoding: 7 > > You should have an explicit check. In my case pg_upgrade does not fail. Old clsuter: - create pg18 cluster with SQL_ASCII encoding - create MULE_INTERNAL encoding database - drop the MULE_INTERNAL database New cluster: - create pg19dev cluster with SQL_ASCII encoding Run pg_upgrade > Other than that, it looks good to me. > >> and I had to think of a new >> name for cyrillic_and_mic.c, so I went with cyrillic.c because it >> handles 4 single-byte encodings and it wasn't clear how to fit into >> the existing x_and_y pattern (ie which two to highlight arbitrarily >> in >> the name). > > Seems fine. Looks good to me as well. Regards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
