Hi, On Thu, Apr 09, 2026 at 11:41:39AM +0000, Bertrand Drouvot wrote: > Hi, > > On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote: > > > > Ok, I have committed the shown patch. > > d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, > so > we really need the one added in test_cplusplusext.cpp?
Now that 66ad764c8d5 is in, the only remaining use of StaticAssertStmt() is in test_cplusplusext.cpp. What about the attached to get rid of it? Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
>From 5f9cf3b5bfb916f71dcc34a5690ad233a175fc13 Mon Sep 17 00:00:00 2001 From: Bertrand Drouvot <[email protected]> Date: Tue, 14 Apr 2026 12:54:45 +0000 Subject: [PATCH v1] Replace deprecated StaticAssertStmt() with StaticAssertDecl() Commit 451650eaacd5 added a test for the StaticAssertStmt() macro in C++ extensions, but it was marked as deprecated in commit d50c86e74375. There is no need to replace it with StaticAssertDecl() (like 66ad764c8d5 did), as the exact same StaticAssertDecl() test has also be added in 451650eaacd5. Author: Bertrand Drouvot <[email protected]> Discussion: https://postgr.es/m/adeQc3I/[email protected] --- src/test/modules/test_cplusplusext/test_cplusplusext.cpp | 1 - 1 file changed, 1 deletion(-) 100.0% src/test/modules/test_cplusplusext/ diff --git a/src/test/modules/test_cplusplusext/test_cplusplusext.cpp b/src/test/modules/test_cplusplusext/test_cplusplusext.cpp index 93cd7dd07f7..ca66c69fe34 100644 --- a/src/test/modules/test_cplusplusext/test_cplusplusext.cpp +++ b/src/test/modules/test_cplusplusext/test_cplusplusext.cpp @@ -51,7 +51,6 @@ test_cplusplus_add(PG_FUNCTION_ARGS) (void) rtr; } - StaticAssertStmt(sizeof(int32) == 4, "int32 should be 4 bytes"); (void) StaticAssertExpr(sizeof(int64) == 8, "int64 should be 8 bytes"); list_free(list); -- 2.34.1
