> On Apr 16, 2026, at 08:06, Amit Langote <[email protected]> wrote: > > Hi, > > On Thu, Apr 16, 2026 at 6:36 AM SATYANARAYANA NARLAPURAM > <[email protected]> wrote: >> >> Hi Hackers, >> >> It appears that pg_overexplain produces invalid JSON output when >> EXPLAIN (FORMAT JSON, RANGE_TABLE) is used. The "Unprunable RTIs" and >> "Result RTIs" properties are emitted as key:value pairs directly inside >> the "Range Table" JSON array, which is structurally invalid. > > Thanks for the report and the patch. That makes sense. > >> Attempted to fix this by moving ExplainCloseGroup() before the two >> overexplain_bitmapset() >> calls, so the properties are emitted as siblings of "Range Table" in the >> parent object rather >> than inside the array. >> >> Attached a patch to address this which also includes a test. > > I have added a commit message. Will commit shortly to master and v18. > > -- > Thanks, Amit Langote > <v1-0001-Fix-pg_overexplain-to-emit-valid-output-with-RANG.patch>
Hi Amit, as the commit message mentions YAML format as well, but I don’t find a test case in pg_overexplain.sql, would it make sense to also add a test case for YAML. I tried to add one, see the attached diff file. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
yaml_test.diff
Description: Binary data
