Hi, On Mon, Apr 20, 2026 at 2:00 AM Alexander Lakhin <[email protected]> wrote: > > Please look at another set of typos and inconsistencies introduced since > 2026-01-01
I've found a few other typos. Although they are quite old, I think they should be mentioned here : 1) Typo in tidstore.c "Find the shared the shared radix tree" --> "Find the shared radix tree". 2) A bit inconsistent comment in twophase.c ``` /* * Recreates a state file. This is used in WAL replay and during * checkpoint creation. * * Note: content and len don't include CRC. */ static void RecreateTwoPhaseFile(FullTransactionId fxid, void *content, int len) ``` This comment was introduced in the implementation of the two-phase commit [1]. At that time, this function was actually used during replaying the XLOG_XACT_PREPARE record. Commit [2] changed that code, so now this function is used only during checkpoint and restartpoint creation. If restartpoint creation can be considered as part of the WAL replay, we can leave this comment as is. Otherwise, I suggest changing it to something like this : /* * Recreates a state file. This is used during checkpoint/restartpoint creation. * * Note: content and len don't include CRC. */ Another idea - we can stop listing the places of function's usage so that we don't need to touch this comment later. [1] d0a89683a3a4dd8e76ef0a99101355999e519df5 [2] 728bd991c3c4389fb39c45dcb0fe57e4a1dccd71 -- Best regards, Daniil Davydov
