On Fri, Apr 17, 2026 at 9:55 PM Amul Sul <[email protected]> wrote: > > Hi, > > I noticed that plsample.c uses an outdated method to convert text data > to a C string. This old method calls the textout function manually, > which adds unnecessary overhead. > > The attached patch replaces this with the TextDatumGetCString() macro. > This macro is more efficient and automatically handles "detoasting" > (decompressing/fetching) the data. > > Since plsample serves as a template for developers writing new > extensions, it should follow current best practices. This patch > updates the code in both the function and trigger handlers.
LGTM. Regards, -- Fujii Masao
