On Wed, Apr 8, 2026 at 3:20 PM cca5507 <[email protected]> wrote: > > > I also thought we should change this cast: > > > > if (ssup->comparator == ssup_datum_signed_cmp) > > { > > - norm_datum1 = orig + ((uint64) PG_INT64_MAX) + 1; > > + norm_datum1 = orig + (Int64GetDatum(PG_INT64_MAX)) + 1; > > } > > > > Upthread you mention something else about treating Datum as an > > integer, but I'm not sure if this is what you meant since you didn't > > say. If you have concrete suggestions, feel free to share them. > > I think we can keep it as is now.
It's harmless, but see commit ff89e182d. I included the assert along with the above and some small cosmetic fixes I've been saving. -- John Naylor Amazon Web Services
