Jeff Davis <[email protected]> writes:
> On Sun, 2026-08-09 at 22:15 -0400, Tom Lane wrote:
>> AFAICS, it's right: if stmt->servername is set while opts.connect is
>> not, we'll arrive at this step with serverid filled in but conninfo
>> still NULL. Even if there's some upstream reason why that
>> combination can't occur, this is pretty fragile-looking code.
> The code relies on the grammar setting either stmt->servername or stmt-
> >conninfo, but not both. I agree that the control flow shouldn't rely
> on that, and the code could be more clear anyway. Patch attached.
Looks good to me, I guess we'll have to see whether it satisfies
Coverity. (But if not, we can just dismiss that complaint.)
regards, tom lane
