Hello! > The patch looks good, just a small suggestion that the function header > of IsIndexUsableForReplicaIdentityFull() probably could do with a > comment so that future callers are aware of this potential shortfall.
Done. > Thanks for the patch, the patch does not apply on PG17 version, you > might have to provide a separate patch for PG17 & below version: Done. > I think it is better to add some comments in the code as well. See > attached. I have added # in the test comments to make it similar to > the previous test. Otherwise, the patch LGTM. Applied, thanks. Regards, Mikhail.
nocfbot-v1-REL_16-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch
Description: Binary data
v1-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch
Description: Binary data
nocfbot-v1-REL_17-0001-Don-t-choose-an-invalid-index-for-REPLICA-IDENTITY-FULL.patch
Description: Binary data
