> On Sep 9, 2026, at 14:55, Fujii Masao <[email protected]> wrote: > > On Wed, Sep 9, 2026 at 1:03 PM Chao Li <[email protected]> wrote: >> So, repack_index_relid now describes the actual scan method but not if index >> ordering was requested. Maybe we should set PROGRESS_REPACK_INDEX_RELID in >> cluster_rel() rather than heapam_relation_copy_for_cluster()? Like in the >> attache diff. > > Thanks for the patch! LGTM. > >> it will translate any REPACK command into one of these other two. > > If we apply the proposed patch, at the same moment, personally I'd like to > update this description of pg_stat_progress_cluster.command in the docs > so that it clearly explains how REPACK is translated. How about: > > it will translate a REPACK command into CLUSTER if index ordering > is requested, > or VACUUM FULL otherwise.
Yes, that makes sense. I added integrated your suggestion into the patch. PFA v2: * 0001 - unchanged from v1-0001 * 0002 - the previous diff plus integrating Fujii-san suggested doc change Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
v2-0001-Don-t-report-CLUSTER-for-a-redacted-progress-row.patch
Description: Binary data
v2-0002-Fix-command-reporting-for-REPACK-using-sequential.patch
Description: Binary data
