Hi Peter, Thanks very much for replacing allocations that were only needed for alignment. I reviewed v4 and did not find any substantive issues.
I checked the alignment, and it is fine: on x86-64 Linux, I get MAXIMUM_ALIGNOF = 8 and alignof(max_align_t) = 16. However, alignof(ControlFileData) is also 8, so MAXIMUM_ALIGNOF is sufficient for the buffer in pg_resetwal's read_controlfile(). The core regression suite and the pg_resetwal and pg_waldump tests passed. Regards, Rui
