Hi,
I re-visited this thread, sorry for quite late. I felt comments from senior
members are still needed to understand the initial intention, but let me share
few comments.
01.
```
retry:
found = false;
+ PushActiveSnapshot(GetLatestSnapshot());
```
Can you put a comment why we need to get the GetLatestSnapshot()? Per my
understanding it's for observing tuples which are updated by concurrent
transactions.
I initially wondered it may break the transaction isolation level REPEATABLE
READ
and the function should return false: but this can lose changes from the
publisher.
02.
You told that this patch does not cause the performance isuse because
GetLatestSnapshot() had already been eventually called, but what if the
update_missing happens? Can the performance decrease in the extreme case which
the lots of XXX_missing happens?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
