On Wed, 2026-10-21 at 23:39 -0400, shihao zhong wrote:
> Hi Andreas,
> 
> > we have so far never added anything to check.c in pg_upgrade for a
> > case like this.
> 
> There is one. In 18, check_for_unicode_update() (b81ffa13e35) warns
> about indexes on lower(), upper(), regexp and normalize() in builtin
> databases when the Unicode version changes.

I don't think I'd like to use that as a precedent for any function
behavior change, it will bloat pg_upgrade with fairly complex queries
that will only get exercised during one cycle. And it will always be
possible to miss some cases (e.g. due to affected code hiding in a SQL
function), so it can give a false sense of security.

I committed the release note changes, and I'll close the open item.

Thank you.

Regards,
        Jeff Davis


Reply via email to