On 11/2/26 12:01, Álvaro Herrera wrote: > On 2026-Nov-02, Tender Wang wrote: > >> As you noted, adding a field to JoinPathExtraData raises an ABI >> concern, so that version of the fix might need to be master-only. > > But nothing allocates JoinPathExtraData anywhere except > add_paths_to_joinrel in its stack; everybody else just receives a > pointer to that. Even the hooks for it receive it as a pointer. I > think the ABI concern is overblown in this case; just make sure to add > the new field at the end. >
You're probably right. I was concerned some extension might be me allocating the struct (as it's in a public header), but I did check a couple extensions that might be doing that (like pg_hint_plan) and I haven't found such cases. So putting the new field at the end should be fine. regards -- Tomas Vondra
