On 29.10.26 12:03, Aleksander Alekseev wrote:
0001: hash_freeze() has not been used since 5dfc198146 (Oct 2016). I
suggest removing it.

This seems alright.  If someone needs it, we can put it back.

0002: hash_destroy() is the only caller of hash_stats(). I suggest
making the function static and place it under `#ifdef
HASH_STATISTICS`.

I don't think this is an improvement. In general, I would like to keep the amount of code covered by #ifdef's as small as possible. That way, we reduce the chances that some code rots because it is not compiled by default. We could make the function static, but I would avoid the additional #ifdef's.



Reply via email to