> On Nov 3, 2026, at 21:31, Etsuro Fujita <[email protected]> wrote:
>
> On Tue, Nov 3, 2026 at 11:51 AM Chao Li <[email protected]> wrote:
>>> <fix-comments.patch>
>>
>> The fix looks good to me.
>>
>> Should we also update the header comment of ExecAppendAsyncEventWait since
>> it only says “wait or poll” without explaining when to wait and when to
>> poll? Something like:
>> ```
>> /*
>> * ExecAppendAsyncEventWait
>> *
>> * Wait or poll for file descriptor events and fire callbacks.
>> * If as_syncdone is true, wait until at least one event occurs;
>> * otherwise, poll without waiting so synchronous execution can
>> proceed.
>> */
>> ```
>
> That would be an improvement rather than a fix, so I'd like to leave
> it for another (master-only) patch.
>
No problem. Would you follow up a patch? Or you’d let me propose one?
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
