Hi, On Wed, Nov 4, 2026 at 12:06 PM shihao zhong <[email protected]> wrote: > > Hi Amit, > > The fix looks right to me. One small thing in the test. Both > subscripts evaluate to 1, so it only sets f2[1]. Maybe use > (1 IS NOT NULL)::int + 1 and add RETURNING f2, so the output > shows both elements: > > insert into inserttest (f2[(select 1)], f2[(1 IS NOT NULL)::int + 1]) > values (9,10), (11,12) returning f2;
Ah, my bad I didn't write it like that to begin with. Done like that. I decided not to go with with Chao's idea of using strip_indirection to skip the copy in this patch in order to keep things simple. I am not sure if being clever won't cause issues later. Thanks for the review though. I'll push the attached updated patch barring objections. -- Thanks, Amit Langote
v2-0001-Fix-multi-row-INSERT-with-a-sublink-in-a-target-c.patch
Description: Binary data
