On 14 November 2017 at 13:12, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Nov 14, 2017 at 12:49 PM, Alvaro Herrera > <alvhe...@alvh.no-ip.org> wrote: >> Here's the remaining bits, rebased. > > It's true that Tom and I reviewed patch 0001, as your proposed commit > message states. But it's also true that we both said that it probably > wasn't a good idea.
I don't see any comments from you or Tom about patch 0001, which was simple refactoring and not much to complain about. Perhaps there is some confusion about the numbering? I see that Alvaro had taken your comments on memory contexts into account in his later patch. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services