On 11/16/2017 10:38 PM, Fabrízio de Royes Mello wrote:
> Hi all,
>
> Attached new version of the patch fixing issues about installcheck and
> some assertions reported before (based on Michael Paquier code):
>
> https://www.postgresql.org/message-id/flat/30479.1510800078%40sss.pgh.pa.us#[email protected]
> https://www.postgresql.org/message-id/flat/20171116121823.GI4628%40tamriel.snowman.net#[email protected]
>
> Regards,
I think this:
#define IsClientBackend() \
(MyBackendId != InvalidBackendId && \
!IsAutoVacuumLauncherProcess() && \
!IsAutoVacuumWorkerProcess() && \
!am_walsender && \
!IsBackgroundWorker)
probably belongs somewhere more central. Surely this isn't the only
place that we want to be able to run such a test?
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services