Dean Rasheed <dean.a.rash...@gmail.com> writes:
> On 27 November 2017 at 16:35, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> On looking closer, the reason it's like that in Fujita-san's patch
>> is to minimize the API churn seen by FDW AddForeignUpdateTargets
>> functions, specifically whether they see a tlist that's before or
>> after what expand_targetlist() does. I'm doubtful that the
>> potential savings is worth taking risks there. In particular,
>> it seems like a good thing that expand_targetlist() verifies the
>> correct tlist ordering *after* the FDW function has acted.
>> So now my inclination is to leave this alone.
> Ah yes, that seems like a worthwhile check to keep. Never mind then.
Pushed with that and some cosmetic fiddling with comments and docs.
Thanks for the discussion!
regards, tom lane
