On Tue, Nov 21, 2017 at 9:26 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > +1. I was also once confused with these macros. I think this is a > good cleanup. On a quick look, I don't see any problem with your > changes.
One difference between those two macros is that IndexTupleSize forcibly casts the argument to IndexTuple, which means that you don't get any type-checking when you use that one. I suggest that in addition to removing IndexTupleDSize as proposed, we also remove that cast. It seems that the only place which relies on that cast currently is btree_xlog_split. Therefore I propose the attached patch instead. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
remove-indextupledsize-v2.patch
Description: Binary data
