On 12/1/17, 3:04 PM, "Robert Haas" <robertmh...@gmail.com> wrote: > On Fri, Dec 1, 2017 at 1:53 PM, Bossart, Nathan <bossa...@amazon.com> wrote: >> There is already an internal flag called VACOPT_NOWAIT that gives >> autovacuum this ability in certain cases (introduced in the aforementioned >> commit), and I recently brought up this potential use-case as >> justification for a patch [0]. I'd be happy to submit a patch for >> providing VACOPT_NOWAIT to users if others think it's something we should >> do. > > Seems entirely reasonable to me, provided that we only update the > extensible-options syntax: > > VACUUM [ ( option [, ...] ) ] [ table_and_columns [, ...] ] > > I don't want to add any more options to the older syntax: > > VACUUM [ FULL ] [ FREEZE ] [ VERBOSE ] [ ANALYZE ] [ table_and_columns [, > ...] ]
Right. This seems like the right path forward to me, as the VACUUM documentation states that the unparenthesized syntax is deprecated, and the DISABLE_PAGE_SKIPPING option was not added to the old syntax, either. > I am slightly confused as to how we got on to this topic since the > subject is "Vacuum crashes", but perhaps Lyes was simply speaking > imprecisely. I'm hoping Lyes chimes in soon to clarify if I am interpreting the original report incorrectly. Nathan
