Re: pg_dumpall -r -c try to drop user postgres

[Michael Paquier]

On Sun, Dec 3, 2017 at 3:21 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote:
> I am not sure if user postgres should be removed, so it is probably bug
>
> pg_dumpall -r -c | grep postgres
>
> DROP ROLE postgres;
> CREATE ROLE postgres;

You are looking for this bit of code:
                /*
                 * If asked to --clean, do that first.  We can avoid detailed
                 * dependency analysis because databases never depend
on each other,
                 * and tablespaces never depend on each other.  Roles could have
                 * grants to each other, but DROP ROLE will clean
those up silently.
                 */
                if (output_clean)
                {
                        if (!globals_only && !roles_only && !tablespaces_only)
                                dropDBs(conn);

                        if (!roles_only && !no_tablespaces)
                                dropTablespaces(conn);

                        if (!tablespaces_only)
                                dropRoles(conn);
                }
Could you clarify what you think is wrong here?
-- 
Michael