On 22 December 2017 at 02:06, Beena Emerson <memissemer...@gmail.com> wrote: >> Thanks for sending. Will the tests still pass if you remove the hack >> from choose_custom_plan()? >> > > The hack has been removed in the v7 patch sent and yes the tests work > without any additional adjustments.
Oh nice. I see you've included parameters to force the 5 custom plans to having a higher cost, then for the first generic plan attempt, you're choosing params that'll result in a cheaper plan. Great idea. I'll revoke what I said about this being impossible to test now :) -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services