On Mon, Jan 8, 2018 at 10:43:00AM -0500, Robert Haas wrote: > On Fri, Jan 5, 2018 at 9:11 PM, Bruce Momjian <br...@momjian.us> wrote: > > On Fri, Jan 5, 2018 at 04:58:39PM -0500, Bruce Momjian wrote: > >> Pg_upgrade is able to run in --check mode when the old server is still > >> running. Unfortunately, all supported versions of pg_upgrade generate > >> an incorrect (but harmless) "failure" message when doing this: > > > > Based on recent discussions, I am thinking we would just fix this in PG > > 10 and HEAD and leave the harmless error message in the other branches, > > right? > > Hmm, not sure why you say that. If the message is buggy and the fix > isn't too risky, might as well fix it all the way back.
OK, I will do that then. The message is harmless, but confusing, so I would like to fix it, but it requires changing the API of two functions. I will see how cleanly it applies back to 9.3 and act accordingly. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
