On Sat, Jan 6, 2018 at 11:17 AM, Peter Geoghegan <p...@bowt.ie> wrote: > * Significant overhaul of tuplesort.h contract. This had references to > the old approach, and to tqueue.c's tuple descriptor thing that was > since superseded by the typmod registry added for parallel hash join. > These were updated/removed.
+1 > * Both tuplesort.c and logtape.c now say that they cannot write to the > writable/last tape, while still acknowledging that it is in fact the > leader tape, and that this restriction is due to a restriction with > BufFiles. They also point out that if the restriction within buffile.c > ever was removed, everything would work fine. +1 > * Added new call to BufFileExportShared() when freezing tape in logtape.c. +1 > * Polished the stuff that is added to buffile.c. Mostly comments that > clarify its reason for existing. Also added Assert()s. +1 This looks good to me. -- Thomas Munro http://www.enterprisedb.com
