On Mon, Dec 4, 2017 at 1:34 PM, Jing Wang <jingwang...@gmail.com> wrote: > I have rebased the patch on the latest version.
Hi Jing, According to my testing robot this fails make check-world (or presumably cd src/bin/pg_dump ; make check), here: t/001_basic.pl ......... ok # Failed test 'binary_upgrade: dumps COMMENT ON DATABASE postgres' # at t/002_pg_dump.pl line 6753. ... masses of dump output omitted ... # Looks like you failed 19 tests of 4727. t/002_pg_dump.pl ....... Dubious, test returned 19 (wstat 4864, 0x1300) Failed 19/4727 subtests t/010_dump_connstr.pl .. ok Test Summary Report ------------------- t/002_pg_dump.pl (Wstat: 4864 Tests: 4727 Failed: 19) Failed tests: 63, 224, 412, 702, 992, 1161, 1330, 1503 1672, 1840, 2008, 2176, 2343, 2495, 2663 3150, 3901, 4282, 4610 Non-zero exit status: 19 There is also a warning from my compiler here: gram.y:1160:19: error: incompatible pointer types assigning to 'char *' from 'Node *' (aka 'struct Node *') [-Werror,-Wincompatible-pointer-types] { (yyval.str) = (yyvsp[0].node); } ^ ~~~~~~~~~~~~~~~ -- Thomas Munro http://www.enterprisedb.com