On Mon, Dec 11, 2017 at 8:25 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: >> Now, if you're still super-concerned about this breaking something, we >> could commit it only to master, where it will have 9 months to bake >> before it gets released. I think that's overly conservative, but I >> think it's still better than waiting for the rewrite you'd like to see >> happen. We don't know when or if anyone is going to undertake that, >> and if we wait, we may easing release a v11 that's got the same defect >> as v9.6 and now v10. And I don't see that we lose much by committing >> this now even if that rewrite does happen in time for v11. Ripping >> out CreateLocalJoinPath() won't be any harder than ripping out >> GetExistingLocalJoinPath(). > > Agreed. Attached is an rebased version which moved the new fields in > JoinPathExtraData to the end of that struct.
FYI this doesn't compile anymore, because initial_cost_hashjoin() and create_hashjoin_path() changed in master. -- Thomas Munro http://www.enterprisedb.com
