On 12 January 2018 at 22:51, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2018/01/12 18:09, David Rowley wrote: >> On 10 January 2018 at 17:18, David Rowley <david.row...@2ndquadrant.com> >> wrote: >>> Basically, the changes to add_paths_to_append_rel() are causing >>> duplication in partition_rels. > >> I also noticed earlier that this is still broken in v19. > > I cannot see the duplication here (with v19 + some local changes per your > latest review, although I had fixed the issue in v18).
I may have made a mistake there. The code I expected to change didn't. I meant to test the case again, but I got distracted just before I did and came back a while later and forgot that I hadn't tested. If you've tested my case and it works, then please don't look any further. I will look when v20 is ready. Sorry for the false alarm... I must've been trying to do too many things at once :-( -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services