I have a small fixes for already committed reloption test patch (https://www.postgresql.org/message-id/2615372.orqtEn8VGB@x200m)
First one is missing tab symbol where it should be. The second is a comment. "The OIDS option is not stored" is not quite correct. They are stored, but not as reloption. I've added this notion there... -- Do code for fun.
diff --git a/src/test/regress/expected/reloptions.out b/src/test/regress/expected/reloptions.out index c4107d5..df3c99d 100644 --- a/src/test/regress/expected/reloptions.out +++ b/src/test/regress/expected/reloptions.out @@ -77,7 +77,7 @@ SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass; ALTER TABLE reloptions_test RESET (autovacuum_enabled, autovacuum_analyze_scale_factor); SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass AND -reloptions IS NULL; + reloptions IS NULL; reloptions ------------ @@ -86,7 +86,7 @@ reloptions IS NULL; -- RESET fails if a value is specified ALTER TABLE reloptions_test RESET (fillfactor); ERROR: RESET must not include values for parameters --- The OIDS option is not stored +-- The OIDS option is not stored as reloption DROP TABLE reloptions_test; CREATE TABLE reloptions_test(i INT) WITH (fillfactor , oids=true); SELECT reloptions, relhasoids FROM pg_class WHERE oid = 'reloptions_test'::regclass; diff --git a/src/test/regress/sql/reloptions.sql b/src/test/regress/sql/reloptions.sql index c9119fd..37fbf41 100644 --- a/src/test/regress/sql/reloptions.sql +++ b/src/test/regress/sql/reloptions.sql @@ -47,12 +47,12 @@ SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass; ALTER TABLE reloptions_test RESET (autovacuum_enabled, autovacuum_analyze_scale_factor); SELECT reloptions FROM pg_class WHERE oid = 'reloptions_test'::regclass AND -reloptions IS NULL; + reloptions IS NULL; -- RESET fails if a value is specified ALTER TABLE reloptions_test RESET (fillfactor); --- The OIDS option is not stored +-- The OIDS option is not stored as reloption DROP TABLE reloptions_test; CREATE TABLE reloptions_test(i INT) WITH (fillfactor , oids=true); SELECT reloptions, relhasoids FROM pg_class WHERE oid = 'reloptions_test'::regclass;
signature.asc
Description: This is a digitally signed message part.
