On Mon, Jan 29, 2018 at 10:32 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > The code is about 1200 lines and has extensive docs, comments and tests. > > There are no contentious infrastructure changes, so the debate around > concurrency is probably the main one. So it looks to me like > meaningful review has taken place, though I know Andrew and Pavan have > also looked at it in detail.
Only design-level review, not detailed review of the code. To be clear, I think the design-level review was quite productive and I'm glad it happened, but it's not a substitute for someone going over the code in detail to look for problems. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
