On Wed, Jan 31, 2018 at 11:53 AM, Dmitry Dolgov <9erthali...@gmail.com> wrote: > Why not write `is_separator_char` using `isprint`, `isalpha`, `isdigit` from > ctype.h? Something like: > > return isprint(*str) && !isalpha(*str) && !isdigit(*str) > > From what I see in the source code they do exactly the same and tests are > successfully passing with this change.
I'm not quite sure whether it's relevant here, but I think some of the ctype.h functions have locale-dependent behavior. By implementing our own test we make sure that we don't accidentally inherit any such behavior. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
