On Tue, Feb 6, 2018 at 4:55 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: >> I understand why COLLATION_MATCH think that a collation OID match is >> OK, but why is InvalidOid also OK? Can you add a comment? Maybe some >> test cases, too? > > partcollid == InvalidOid means the partition key is of uncollatable type, > so further checking the collation is unnecessary.
Yeah, but in that case wouldn't BOTH OIDs be InvalidOid, and thus the equality test would mach anyway? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company