On 2/7/18 23:18, Michael Paquier wrote:
> You need to update the comment on top of test_connect_ok in
> ServerSetup.pm.

done and committed

> Wouldn't it be better to use the expected result
> as an argument and merge test_connect_ok and test_connect_fails?

That doesn't seem to be the general style, and I think it's more
readable the way it is now.

Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply via email to