On 2018-02-15 20:11:07 +0900, Kyotaro HORIGUCHI wrote: > As in another mail just before, spin.c seems a bit strange > (without acutual harm). > > spin.h doesn't include pg_sema.h when HAVE_SPINLOCKS is defined, > but spin.c always includes it even in the case. The file is > included only to use sizeof(PGSemaphore) to calcualte > SpinlockSemaSize as 0. > > The codes that requires PGSempaphore is inactivated when the > symbol is defined in all other places so it seems to me that we > ought to refrain from using it there, too. The attched patch does
IDK, I don't quite see the point of the change here... Greetings, Andres Freund
