On Thu, Mar 1, 2018 at 4:43 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 2/27/18 00:56, Thomas Munro wrote:
>> FWIW it passes for me if I add this:
>> +elsif ($^O eq 'freebsd')
>> +{
>> +       $krb5_bin_dir = '/usr/local/bin';
>> +       $krb5_sbin_dir = '/usr/local/sbin';
> I suppose you only need the second one, right?  The first one should be
> in the path.

Erm.  Turned out I had a couple of different versions in my path, but
your test only works with the binaries in the paths shown above (the
binaries installed from ports, or rather pkg install krb5, not the
ones from the base system).

munro@asterix $ /usr/bin/krb5-config --version
FreeBSD heimdal 1.1.0
munro@asterix $ /usr/local/bin/krb5-config --version
Kerberos 5 release 1.15.2

>> One thing that surprised me is that your test runs my system's
>> installed psql command out of my $PATH, not the one under test.  Is
>> that expected?
> Oh, you probably have a psql in /usr/local/bin, which we prepend to the
> path, per the above.  We should probably append instead.  The ldap test
> suite has the same issue.

Hmm.  Not sure if appending is right either, since then you wouldn't
get the krb5_bin_dir etc in preference to the user's preexisting PATH,
so you'd break my attempt to use krb5-config 1.15.2 instead of heimdal
1.1.0.  Maybe you need to prepend the user's krb5_bin_dir etc, and
then finally prepend the tmp install bin dir wherever that happens?
Or maybe you want to build absolute paths from the paths you have?  I
didn't look at how this perl code is structured...

Thomas Munro

Reply via email to