On 2018-03-02 11:49:05 -0500, Robert Haas wrote: > On Thu, Mar 1, 2018 at 8:25 PM, Andres Freund <and...@anarazel.de> wrote: > > On 2018-02-02 11:37:34 +1300, Thomas Munro wrote: > >> > 3. pg_upgrade isn't considered. This patch should provide upgrading > >> > SLRUs > >> > to adopt changed useful size of page. That seems to be hardest patch of > >> > this patch to be written. > >> > >> +1 > >> > >> I think we'd want pg_upgrade tests showing an example of each SLRU > >> growing past one segment, and then being upgraded, and then being > >> accessed in various different pages and segment files, so that we can > >> see that we're able to shift the data to the right place successfully. > >> For example I think I'd want to see that a single aborted transaction > >> surrounded by many committed transactions shows up in the right place > >> after an upgrade. > > > > This patch is in the 2018-03 CF, but I don't see any progress since the > > last comments. As it has been Waiting on author since the last CF, I > > think we should mark this as returned with feedback. > > +1.