On 2018-02-22 11:10:57 -0500, Robert Haas wrote:
> On Tue, Feb 20, 2018 at 8:06 PM, Amit Langote
> <langote_amit...@lab.ntt.co.jp> wrote:
> >> Attached is an updated version for that.
> >
> > Thanks for updating the patch.
> Committed with a few changes.  The big one was that I got rid of the
> local variable is_update in ExecSetupPartitionTupleRouting.  That
> saved a level of indentation on a substantial chunk of code, and it
> turns out that test was redundant anyway.

Btw, are there cases where this could change explain output?  If there's
subplan references or such in any of returning / wcte expressions,
they'd not get added at explain time.  It's probably fine because add
the expressions also "staticly" in ExecInitModifyTable()?


Andres Freund

Reply via email to