On 2018-03-05 09:21:33 +0000, Simon Riggs wrote: > On 2 March 2018 at 07:18, Andres Freund <and...@anarazel.de> wrote: > > Hi, > > > > On 2018-02-28 22:35:52 -0500, Peter Eisentraut wrote: > >> This feature is meant to help manage transaction isolation in > >> procedures. > > > > This is a major new feature, submitted the evening before the last CF > > for v11 starts. Therefore I think it should just be moved to the next > > fest, it doesn't seems realistic to attempt to get this into v11. > > Looks like a useful patch that adds fairly minor syntax that follows > the SQL Standard. > > It introduces no new internal infrastructure, so I can't call this a > major feature.
You can avoid calling it new infrastructure, but it certainly modifies new one. And it adds quite some new user interface, which certainly make s it important to get it right. doc/src/sgml/plpgsql.sgml | 9 doc/src/sgml/ref/abort.sgml | 14 + doc/src/sgml/ref/commit.sgml | 14 + doc/src/sgml/ref/end.sgml | 14 + doc/src/sgml/ref/rollback.sgml | 14 + doc/src/sgml/spi.sgml | 14 - src/backend/access/transam/xact.c | 210 +++++++++++--------- src/backend/commands/cluster.c | 2 src/backend/commands/dbcommands.c | 2 src/backend/commands/discard.c | 2 src/backend/commands/portalcmds.c | 2 src/backend/commands/subscriptioncmds.c | 4 src/backend/commands/typecmds.c | 2 src/backend/commands/vacuum.c | 4 src/backend/commands/variable.c | 57 ----- src/backend/executor/spi.c | 25 ++ src/backend/nodes/copyfuncs.c | 2 src/backend/nodes/equalfuncs.c | 2 src/backend/parser/gram.y | 34 +-- src/backend/replication/walsender.c | 6 src/backend/tcop/utility.c | 58 ++--- src/backend/utils/misc/guc.c | 35 +-- src/backend/utils/time/snapmgr.c | 2 src/bin/psql/common.c | 2 src/include/access/xact.h | 18 - src/include/commands/variable.h | 4 src/include/executor/spi.h | 4 src/include/nodes/parsenodes.h | 4 src/pl/plperl/plperl.c | 4 src/pl/plpgsql/src/expected/plpgsql_transaction.out | 31 ++ src/pl/plpgsql/src/pl_exec.c | 10 src/pl/plpgsql/src/pl_funcs.c | 10 src/pl/plpgsql/src/pl_gram.y | 18 + src/pl/plpgsql/src/pl_scanner.c | 2 src/pl/plpgsql/src/plpgsql.h | 2 src/pl/plpgsql/src/sql/plpgsql_transaction.sql | 23 ++ src/pl/plpython/plpy_plpymodule.c | 4 src/pl/tcl/pltcl.c | 4 src/test/regress/expected/transactions.out | 141 +++++++++++++ src/test/regress/sql/transactions.sql | 49 ++++ 40 files changed, 596 insertions(+), 262 deletions(-) Greetings, Andres Freund
