On 3/1/18 11:18 PM, Michael Paquier wrote: > > Based on my recent lookup at code level for this feature, the patch for > pg_resetwal (which could have been discussed on its own thread as well), > would be fine for commit. The thing could be extended a bit more but > there is nothing opposing even a basic test suite to be in.
There are no core changes, so it doesn't seem like the tests can hurt anything. > Then you > have a set of refactoring patches, which still need some work. New patches posted today, hopefully those address most of your concerns. > And > finally there is a rather invasive patch on top of the whole thing. I'm not sure if I would call it invasive since it's an optional feature that is off by default. Honestly, I think the refactor in 02 is more likely to cause problems even if the goal there is *not* to change the behavior. > The > refactoring work shows much more value only after the main feature is > in, still I think that unifying the default permissions allowed for > files and directories, as well as mkdir() calls has some value in > itself to think it as an mergeable, independent, change. I agree. > I think that > it would be hard to get the whole patch set into the tree by the end of > the CF though I hope it does make it, it's a pretty big win for security. > but cutting the refactoring pieces would be doable. At > least it would provide some base for integration in v12. And the > refactoring patch has some pieces that would be helpful for TAP tests as > well. I've gone pretty big on tests in this patch because I recognize it is a pretty fundamental behavior change. Thanks, -- -David da...@pgmasters.net
signature.asc
Description: OpenPGP digital signature
