On 3/11/18 05:11, Michael Paquier wrote: > On Fri, Mar 09, 2018 at 05:23:48PM -0500, Peter Eisentraut wrote: >> This seems like a useful test. >> >> On 3/5/18 12:35, David Steele wrote: >>> +mkdir($tablespaceDir) >>> + or die "unable to mkdir \"$tablespaceDir\""; >> >> Use BAIL_OUT instead of die in tests. > > Would it be better to make this practice more uniform? From the code of > the tests: > $ git grep die -- */t/*.pl | wc -l > 50
Yes, or maybe there is a way to "catch" die and turn it into BAIL_OUT? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services