On 14 March 2018 at 13:27, Andres Freund <and...@anarazel.de> wrote:
> In the attached *POC* patch I've added a 'unit' parameter to the numeric
> ExplainProperty* functions, which EXPLAIN_FORMAT_TEXT adds to the
> output. This can avoid the above and other similar branches (of which
> the JIT patch would add a number).
This seems like a good change. It would be nice to see us completely
get rid of all the appendStringInfo* calls, apart from in the
functions which meant to handle the behaviour specific to the explain
format. This is a step towards that, so has my vote.
Functions like show_hash_info are making it difficult to do more in this area.
David Rowley http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services